logging: improve ffmpeg error message quality#37
Merged
Conversation
Many failed upload jobs just say 'ffmpeg failed see logs.' This commit should fix that and dump the ffmpeg stderr to the calling process' log. In addition, I am surfacing the traceback for that error.
Runners that only surface str(exception) (e.g. unattended SLURM/singularity jobs spawned via aind-data-transfer-service) previously saw only "One or more Ffmpeg jobs failed. See error logs." with no stderr or per-job context. Inline the formatted failure blocks into the RuntimeError so the diagnostic info travels with the exception itself. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extract the parallel and serial execution paths into _run_parallel and _run_serial helpers so _run_compression itself stays under flake8's max-complexity = 10. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jtyoung84
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many failed upload jobs just say 'ffmpeg failed see logs.' This commit should fix that and dump the ffmpeg stderr to the calling process' log. In addition, I am surfacing the traceback for that error.